Skip to main content

Applications bugs that can be caused by 'ref' keyword

Zilele acestea ma uitam peste un cod si am intalnit urmatoarea linie de cod:
Foo foo1 = new Foo();
...
Foo foo2 = foo1;
...
DoSomeAction(ref foo1)
{   
    ...
    foo1 = new Foo();
    ...
}
...
Pentru unele cazuri se ajungea ca in interiorul metodei DoSomeAction sa se creeze o noua instanta a obiectului Foo. Iar in unele cazuri aplicatia crapa intr-o alta locatie destul de urat. Nu o sa incep sa explic ce face keyword-ul ref si out.
Totusi am adaugat un citiat din MSDN ca sa pornim de la un punct comun.
The ref keyword causes an argument to be passed by reference, not by value. The effect of passing by reference is that any change to the parameter in the method is reflected in the underlying argument variable in the calling method. The value of a reference parameter is always the same as the value of the underlying argument variable. An argument that is passed to a ref parameter must be initialized before it is passed. This differs from out parameters, whose arguments do not have to be explicitly initialized before they are passed. For more information

Problema care apare in acest caz apare atat in cazul la ref cat si in out, dar in cazul la out. In momentul cand s-a facut atribuirea "foo2 = foo1", adresa de memorie spre care bate foo2 o sa fie aceiasi cu foo1. In interiorul metodei DoSomeAction ajungem sa cream un nou obiect de tip Foo, iar adresa de memorie spre care puncteaza foo1 se schimba cu o valoare noua. Dar foo2 o sa continue sa puncteze spre vechia adresa din memorie.
Din aceasta cauza foo2 ajunge sa puncteze spre vechia valoare, iar foo1 spre noua valoare.
Acest comportament este normal pentru ref si out, nu este nici o anomalie a limbajului. Intrebarea mea este urmatoare: Codul scris mai sus face ce ar trebui sa faca?
Raspunsul meu este ca NU. Daca vrem sa inlocuim un obiect cu alt obiect trebuie sa avem grija sa facem update la toate referintele acestuia sau poate nu e nevoie sa facem new la obiect si ajunge sa schimba doar cateva valori interne din obiect.

Comments

  1. As zice ca totusi codul face ceea ce ar trebui sa faca (in lipsa mai multor info) - cine a adaugat acolo ref, daca nu era beat, a facut-o cu scopul ca metoda sa aiba side effects, si sa poata modifica valoarea parametrilor (bad style, da' asta e alta poveste).

    ReplyDelete

Post a Comment

Popular posts from this blog

How to audit an Azure Cosmos DB

In this post, we will talk about how we can audit an Azure Cosmos DB database. Before jumping into the problem let us define the business requirement: As an Administrator I want to be able to audit all changes that were done to specific collection inside my Azure Cosmos DB. The requirement is simple, but can be a little tricky to implement fully. First of all when you are using Azure Cosmos DB or any other storage solution there are 99% odds that you’ll have more than one system that writes data to it. This means that you have or not have control on the systems that are doing any create/update/delete operations. Solution 1: Diagnostic Logs Cosmos DB allows us activate diagnostics logs and stream the output a storage account for achieving to other systems like Event Hub or Log Analytics. This would allow us to have information related to who, when, what, response code and how the access operation to our Cosmos DB was done. Beside this there is a field that specifies what was th...

Can User Technical Profile Influence AI Architecture Decisions?

In the last few days, I ran a small experiment on Devin/Windsurf/Cascade, BMAD, and LLM-based architecture decisions. The initial concern was simple: if an AI coding assistant knows something about the user, for example, that the user is a Java developer or a .NET developer, can this information influence the architecture and technology stack that the AI will propose? This question is important because many companies are starting to use AI tools not only for coding but also for product discovery, architecture, documentation, and technical decision-making. If the AI is influenced by the developer's personal profile, the result may not be fully neutral. It may look like a business or architecture decision, but in reality, it may be partially shaped by the context of the person using the tool. The test was done using BMAD with Devin/Windsurf/Cascade. The scenario was a unified field service operations platform. The task was to let BMAD refine the product, define the architecture and s...

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see...