Skip to main content

Applications bugs that can be caused by 'ref' keyword

Zilele acestea ma uitam peste un cod si am intalnit urmatoarea linie de cod:
Foo foo1 = new Foo();
...
Foo foo2 = foo1;
...
DoSomeAction(ref foo1)
{   
    ...
    foo1 = new Foo();
    ...
}
...
Pentru unele cazuri se ajungea ca in interiorul metodei DoSomeAction sa se creeze o noua instanta a obiectului Foo. Iar in unele cazuri aplicatia crapa intr-o alta locatie destul de urat. Nu o sa incep sa explic ce face keyword-ul ref si out.
Totusi am adaugat un citiat din MSDN ca sa pornim de la un punct comun.
The ref keyword causes an argument to be passed by reference, not by value. The effect of passing by reference is that any change to the parameter in the method is reflected in the underlying argument variable in the calling method. The value of a reference parameter is always the same as the value of the underlying argument variable. An argument that is passed to a ref parameter must be initialized before it is passed. This differs from out parameters, whose arguments do not have to be explicitly initialized before they are passed. For more information

Problema care apare in acest caz apare atat in cazul la ref cat si in out, dar in cazul la out. In momentul cand s-a facut atribuirea "foo2 = foo1", adresa de memorie spre care bate foo2 o sa fie aceiasi cu foo1. In interiorul metodei DoSomeAction ajungem sa cream un nou obiect de tip Foo, iar adresa de memorie spre care puncteaza foo1 se schimba cu o valoare noua. Dar foo2 o sa continue sa puncteze spre vechia adresa din memorie.
Din aceasta cauza foo2 ajunge sa puncteze spre vechia valoare, iar foo1 spre noua valoare.
Acest comportament este normal pentru ref si out, nu este nici o anomalie a limbajului. Intrebarea mea este urmatoare: Codul scris mai sus face ce ar trebui sa faca?
Raspunsul meu este ca NU. Daca vrem sa inlocuim un obiect cu alt obiect trebuie sa avem grija sa facem update la toate referintele acestuia sau poate nu e nevoie sa facem new la obiect si ajunge sa schimba doar cateva valori interne din obiect.

Comments

  1. As zice ca totusi codul face ceea ce ar trebui sa faca (in lipsa mai multor info) - cine a adaugat acolo ref, daca nu era beat, a facut-o cu scopul ca metoda sa aiba side effects, si sa poata modifica valoarea parametrilor (bad style, da' asta e alta poveste).

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(...

How to audit an Azure Cosmos DB

In this post, we will talk about how we can audit an Azure Cosmos DB database. Before jumping into the problem let us define the business requirement: As an Administrator I want to be able to audit all changes that were done to specific collection inside my Azure Cosmos DB. The requirement is simple, but can be a little tricky to implement fully. First of all when you are using Azure Cosmos DB or any other storage solution there are 99% odds that you’ll have more than one system that writes data to it. This means that you have or not have control on the systems that are doing any create/update/delete operations. Solution 1: Diagnostic Logs Cosmos DB allows us activate diagnostics logs and stream the output a storage account for achieving to other systems like Event Hub or Log Analytics. This would allow us to have information related to who, when, what, response code and how the access operation to our Cosmos DB was done. Beside this there is a field that specifies what was th...

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills)

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills) The idea that moving to the cloud reduces the costs is a common misconception. The cloud infrastructure provides flexibility, scalability, and better CAPEX, but it does not guarantee lower costs without proper optimisation and management of the cloud services and infrastructure. Idle and unused resources, overprovisioning, oversize databases, and unnecessary data transfer can increase running costs. The regional pricing mode, multi-cloud complexity, and cost variety add extra complexity to the cost function. Cloud adoption without a cost governance strategy can result in unexpected expenses. Improper usage, combined with a pay-as-you-go model, can result in a nightmare for business stakeholders who cannot track and manage the monthly costs. Cloud-native services such as AI services, managed databases, and analytics platforms are powerful, provide out-of-the-shelve capabilities, and increase business agility and innovation. H...