Skip to main content

[Code refactoring] HttpClient status code

Last night I had some time to look over a project that is on CodePlex. There I found the following code:
using (var httpClient = new HttpClient())
{
  httpClient.BaseAddress = fooUrl;
  FooMessage message = new FooMessage()
  {
    ...
  }
  Task<HttpResponseMessage> response = httpClient.PostAsJsonAsync("api/foo", message);
  response.Wait();
    if (response.Result.StatusCode != HttpStatusCode.OK)
                {
                    throw new Exception("...");
                }
}
What do you see strange in this code?
Well, there is a check if the return code was 200 (OK) and if not, throw an exception.
This is not the wrong way to go, but you should know that HttpClient already contains a method that can check if the return code was 200 (OK). This method will throw an exception automatically if the return code is not the expected one.
The above code could be written in the following way:
using (var httpClient = new HttpClient())
{
  httpClient.BaseAddress = fooUrl;
  FooMessage message = new FooMessage()
  {
    ...
  }
  Task<HttpResponseMessage> response = httpClient.PostAsJsonAsync("api/foo", message);
  response.Wait();
  response.Result.EnsureSuccessStatusCode();
}
If you wouldn't want to throw an exception, only to check if the status code was okay you could also use the property IsSuccessStatusCode of the result.

The most important thing is to know the available API when you start to use different core features.

Comments

  1. The two codes are not equivalent, guess why? :)
    (depending on the problem, the first or the second one might be buggy, or none)

    ReplyDelete

Post a Comment

Popular posts from this blog

How to audit an Azure Cosmos DB

In this post, we will talk about how we can audit an Azure Cosmos DB database. Before jumping into the problem let us define the business requirement: As an Administrator I want to be able to audit all changes that were done to specific collection inside my Azure Cosmos DB. The requirement is simple, but can be a little tricky to implement fully. First of all when you are using Azure Cosmos DB or any other storage solution there are 99% odds that you’ll have more than one system that writes data to it. This means that you have or not have control on the systems that are doing any create/update/delete operations. Solution 1: Diagnostic Logs Cosmos DB allows us activate diagnostics logs and stream the output a storage account for achieving to other systems like Event Hub or Log Analytics. This would allow us to have information related to who, when, what, response code and how the access operation to our Cosmos DB was done. Beside this there is a field that specifies what was th...

Why Database Modernization Matters for AI

  When companies transition to the cloud, they typically begin with applications and virtual machines, which is often the easier part of the process. The actual complexity arises later when databases are moved. To save time and effort, cloud adoption is more of a cloud migration in an IaaS manner, fulfilling current, but not future needs. Even organisations that are already in the cloud find that their databases, although “migrated,” are not genuinely modernised. This disparity becomes particularly evident when they begin to explore AI technologies. Understanding Modernisation Beyond Migration Database modernisation is distinct from merely relocating an outdated database to Azure. It's about making your data layer ready for future needs, like automation, real-time analytics, and AI capabilities. AI needs high throughput, which can be achieved using native DB cloud capabilities. When your database runs in a traditional setup (even hosted in the cloud), in that case, you will enc...

Azure Service Bus - How to extend the lock of a message | RenewLock

In this post we will discuss about Azure Service Bus Topics and Queues, with a special focus on Peek and Lock feature. Introduction Azure Service Bus is a messaging system that allows us to send messages between different systems in a reliable and easy way. A lot of concepts from ESB are implemented by Service Bus, allowing us to do do magic stuff with messages. There are two ways to consume messages from Service Bus Peek and Lock - locks a message for a specific time internal and notify Service Bus when we want to mark the message as processed (removed from Service Bus) Receive and Delete  - once a message is received from Service Bus, it is also deleted automatically from the messaging system Peek and Lock When using Peek and Lock, by default we lock the message for 60 seconds. This means that in this time interval the message is not available/visible for other consumers. Once we process the message we can mark it as processed. If we don't mark the message as processe...