Skip to main content

How to extract a file extension from a string path

Cautand ceva printr-o aplicatie am gasit urmatoarele linii de cod:
foreach (Foo foo in contaner.Foos)
{
if ( foo .FileName.EndsWith(".exe") )
{
// executa o actiune
}
}
Ce vi se pare ciudat in codul de mai sus?
Ce mi-a sarit mie in ochi in primul moment a fost modul in care se verifica daca extensia la fisier este ".exe". .NET ne pune la dispoztie clasa System.IO.Path, prin intermediul careia putem sa extragem numele de fisier, extensia, full path-ul, root path etc.
In cazul nostru putem sa folosim metoda Path.GetExtension(string). Aceasta metoda o sa ne returneze extensia fisierului, daca fisierul are extensie, iar in cazul in care fisierul nostru nu are extensie atunci o sa returneze stringul gol( String.Empty).
Dar ce se intampla in cazul in care path-ul pe care noi il dam este NULL? Valoarea care o sa fie returnata o sa fie la randul ei NULL.
Codul de mai sus l-am putea rescrie in felul urmator:
foreach (Foo foo in contaner.Foos)
{
if ( Path.GetExtension(foo .FileName) == ".exe" )
{
// executa o actiune
}
}
Nu trebuie sa uitam ca exista si metoda Path.HasExtension(string), care o sa returneze TRUE, daca path-ul dat contine o extensie. In cazul de mai sus nu e nevoie sa facem aceasta verificare, deoarece GetExtension o sa ne returneze mereu string-ul Empty daca fisierul nu contine nici o extensie.
Dar trebuie sa avem grija sub ce forma este extensia. Daca pentru noi "exe" este egal cu "eXe" si cu "EXE", atunci verificarea de egalitate trebuie sa fie facuta folosind metoda Equals. Codul nostru ar trebuie sa fie rescris in felul urmator:
foreach (Foo foo in contaner.Foos)
{
if ( Path.GetExtension(foo .FileName).Equals(".exe", StringComparison.InvariantCultureIgnoreCase )
{
// executa o actiune
}
}
As vrea sa atrag atentia ca metoda Path.GetExtension(string) ne returneaza extensia unui fisier inclusiv cu ".". De exemplu pentru "foo.exe", valoarea returnata o sa fie ".exe".
Enjoy!

Comments

  1. Daca nu vrei sa afli care e extensia (fara sa o stii in prealabil), ci doar vrei sa verifici ca extensia e sau nu un anume string (".exe" in cazul asta), prima varianta mi se pare ok
    (si poate si o idee mai eficienta daca se foloseste OrdinalIgnoreCase, nu InvariantCultureIgnoreCase).

    Singura lipsa ar fi faptul ca e case si culture-sensitive, dar EndsWith are si un overload care accepta un StringComparation.

    Normal, prima varianta e ok doar daca presupunem ca definitia a ce inseamna 'extension' ramane aceeasi in viitor.. :)

    ReplyDelete
  2. .ToLower poate sa fie si aceasta o solutie. Personal prefer sa folosesc Equal in loc de ToLower si ==. Mi se pare mult mai clar si nu e nevoie sa apelez ToLower pentru ambele string-uri pe care le compar( daca nu sunt constante). Dar depinde de caz si de preferintele fiecaruia.

    Pentru a extrage extensia unui fisier nu as evita EndsWith. Daca intr-un API a unui framework avem deja un mecanism pentru o anumite functionalitate deja implementat, prefer sa o folosesc pe aceasta( teoretic ar trebuii sa fie mai sigura si sa nu genereze erori).
    In acest caz mi se pare mult mai lizibil codul folosind GetExtension. Cel care citeste isi da seama mai usor ce se intampla acolo.

    ReplyDelete
  3. Pai asta ziceam, ca in cazul de mai sus nu e nevoie sa extragi extensia unui file name (pentru ca stii deja care ar trebui sa fie extensia).. :)
    Intr-adevar, cu GetExtension codul e ceva mai usor de inteles - o alta varianta, ca sa fie clara intentia ar fi:
    string expectedExtension = ".exe";
    if ( foo.FileName.EndsWith(expectedExtension, ...) ) ...

    ReplyDelete
  4. Hai ca facem semantica cu totii...

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(

Azure AD and AWS Cognito side-by-side

In the last few weeks, I was involved in multiple opportunities on Microsoft Azure and Amazon, where we had to analyse AWS Cognito, Azure AD and other solutions that are available on the market. I decided to consolidate in one post all features and differences that I identified for both of them that we should need to take into account. Take into account that Azure AD is an identity and access management services well integrated with Microsoft stack. In comparison, AWS Cognito is just a user sign-up, sign-in and access control and nothing more. The focus is not on the main features, is more on small things that can make a difference when you want to decide where we want to store and manage our users.  This information might be useful in the future when we need to decide where we want to keep and manage our users.  Feature Azure AD (B2C, B2C) AWS Cognito Access token lifetime Default 1h – the value is configurable 1h – cannot be modified

What to do when you hit the throughput limits of Azure Storage (Blobs)

In this post we will talk about how we can detect when we hit a throughput limit of Azure Storage and what we can do in that moment. Context If we take a look on Scalability Targets of Azure Storage ( https://azure.microsoft.com/en-us/documentation/articles/storage-scalability-targets/ ) we will observe that the limits are prety high. But, based on our business logic we can end up at this limits. If you create a system that is hitted by a high number of device, you can hit easily the total number of requests rate that can be done on a Storage Account. This limits on Azure is 20.000 IOPS (entities or messages per second) where (and this is very important) the size of the request is 1KB. Normally, if you make a load tests where 20.000 clients will hit different blobs storages from the same Azure Storage Account, this limits can be reached. How we can detect this problem? From client, we can detect that this limits was reached based on the HTTP error code that is returned by HTTP