Skip to main content

How to compare two generic dictionaries

Zilele acestea mi-a fost pusa urmatoarea intrebare:
Intr-un unit test care este cea mai buna modalitate de a compara doua colectii?

Daca va aduceti aminte, in urma cu cateva saptamani am discutat despre CollectionAssert. Aceasta contine o metoda denumita AreEquivalent, care verifica daca doua colectii sunt echivalente. Testul o sa treaca de acest assert daca:
  • numarul de elemente este egal
  • cele doua colectii contin aceleasi elemente( indiferent de ordinea in care apar)
Doua elemente din colectie sunt egale nu daca puncteaza spre acelasi element ci daca sunt egale prin continut( se apeleaza metoda Equals, pentru a face aceasta verificare). In cazul nostru, metoda AreEquivalent o sa itereze prin intreaga colectie de element KeyValuePair pe care un dictionar le contine.
Dictionary<string,string> collection1=new Dictionary<string, string>();
Dictionary<string, string> collection2 = new Dictionary<string, string>();
...
CollectionAssert.AreEquivalent(collection1,collection2);
In cazul in care avem nevoie in cod sa comparam doua dictionare putem sa face in felul urmator:
collection1
.OrderBy(i => i)
.SequenceEqual(collection2.OrderBy(i => i));
Varianta de mai sus este O(n*log(n)). In cazul in care vreti o solutie in O(n), puteti sa incercati o implementare asemanatoare cu aceasta:
public class CollectionComparer<T> : IEqualityComparer<IEnumerable<T>>
where T : class
{
public bool Equals(IEnumerable<T> collection1, IEnumerable<T> collection2)
{
if ((collection1 == null && collection2!=null)
|| (collection2 == null && collection1!=null))
{
return false;
}

if (ReferenceEquals(collection1, collection2))
{
return true;
}

int collection1Count = collection1.Count();
if (collection1Count != collection2.Count())
{
return false;
}

return collection1Count == 0
|| !AreCollectinDifferent(collection1, collection2);
}

private static bool AreCollectinDifferent(IEnumerable<T> collection1, IEnumerable<T> collection2)
{
int collection1Count;
int collection2Count;

var firstElementCounts = GetElementCounts(collection1, out collection1Count);
var secondElementCounts = GetElementCounts(collection2, out collection2Count);

if (collection1Count != collection2Count)
{
return true;
}

foreach (KeyValuePair<T,int> keyValuePair in firstElementCounts)
{
collection1Count = keyValuePair.Value;
secondElementCounts.TryGetValue(keyValuePair.Key, out collection2Count);

if (collection1Count != collection2Count)
{
return true;
}
}

return false;
}

private static Dictionary<T, int> GetElementCounts(IEnumerable<T> enumerable,
out int nullCount)
{
var dictionary = new Dictionary<T, int>();
nullCount = 0;
int value;

foreach (T element in enumerable)
{
if (element == null)
{
nullCount++;
continue;
}


dictionary.TryGetValue(element, out value);
dictionary[element] = ++value;
}

return dictionary;
}

public int GetHashCode(IEnumerable<T> enumerable)
{
return enumerable
.OrderBy(x => x)
.Aggregate(
11,
(current, val) => current*13 + val.GetHashCode());
}
}

Enjoy!

Comments

  1. 11 si 13 ce reprezinta? :)

    Interesant ca si implementare- altfel, daca timpul m-ar fi presat as fi raspuns la intrebare: foloseste ceva gata facut, precum http://comparenetobjects.codeplex.com/ (l-am folosit in unit teste, si merge brici, exceptand niste situatii destul de particulare)

    ReplyDelete
  2. Am implementat o functie de hash. Ma asteptam ca cineva sa se ia de functie de hash. Nu e cel mai bun algoritm acolo oricum.
    + o bere Tudor pe cand te intorci :D

    ReplyDelete
  3. Imi dau seama ca e o functie de hash, eram curios de ce 13 si nu.. 15.. :)

    ReplyDelete

Post a Comment

Popular posts from this blog

Why Database Modernization Matters for AI

  When companies transition to the cloud, they typically begin with applications and virtual machines, which is often the easier part of the process. The actual complexity arises later when databases are moved. To save time and effort, cloud adoption is more of a cloud migration in an IaaS manner, fulfilling current, but not future needs. Even organisations that are already in the cloud find that their databases, although “migrated,” are not genuinely modernised. This disparity becomes particularly evident when they begin to explore AI technologies. Understanding Modernisation Beyond Migration Database modernisation is distinct from merely relocating an outdated database to Azure. It's about making your data layer ready for future needs, like automation, real-time analytics, and AI capabilities. AI needs high throughput, which can be achieved using native DB cloud capabilities. When your database runs in a traditional setup (even hosted in the cloud), in that case, you will enc...

Cloud Myths: Migrating to the cloud is quick and easy (Pill 2 of 5 / Cloud Pills)

The idea that migration to the cloud is simple, straightforward and rapid is a wrong assumption. It’s a common misconception of business stakeholders that generates delays, budget overruns and technical dept. A migration requires laborious planning, technical expertise and a rigorous process.  Migrations, especially cloud migrations, are not one-size-fits-all journeys. One of the most critical steps is under evaluation, under budget and under consideration. The evaluation phase, where existing infrastructure, applications, database, network and the end-to-end estate are evaluated and mapped to a cloud strategy, is crucial to ensure the success of cloud migration. Additional factors such as security, compliance, and system dependencies increase the complexity of cloud migration.  A misconception regarding lift-and-shits is that they are fast and cheap. Moving applications to the cloud without changes does not provide the capability to optimise costs and performance, leading to ...

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills)

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills) The idea that moving to the cloud reduces the costs is a common misconception. The cloud infrastructure provides flexibility, scalability, and better CAPEX, but it does not guarantee lower costs without proper optimisation and management of the cloud services and infrastructure. Idle and unused resources, overprovisioning, oversize databases, and unnecessary data transfer can increase running costs. The regional pricing mode, multi-cloud complexity, and cost variety add extra complexity to the cost function. Cloud adoption without a cost governance strategy can result in unexpected expenses. Improper usage, combined with a pay-as-you-go model, can result in a nightmare for business stakeholders who cannot track and manage the monthly costs. Cloud-native services such as AI services, managed databases, and analytics platforms are powerful, provide out-of-the-shelve capabilities, and increase business agility and innovation. H...