Skip to main content

Field like events and polymorphic invocation

Ce vi se pare gresit in codul de mai jos:
public class Base
{
public virtual event EventHandler EventOne;
}
public class Derived : Base
{
public override event EventHandler EventOne;
public void DoAction()
{
...
EventOne(this, args);
}
}
In clasa de baza avem un eveniment la care se poate face override in orice clasa derivata. Desi la prima vedere totul pare sa fie in ordine daca ne uitam mai atent, putem sa observam o problema care poate sa apara din cauza la override.
EventOne o sa existe in doua locatii diferite, atat in clasa de baza cat si in clasa derivata. Din aceasta cauza o sa fie momente cand EventOne din clasa de baza nu o sa fie niciodata instantiat.
Din aceasta cauza, in cazul in care evenimentul este apelat din clasa de baza ne putem trezi cu un comportament ciudat, precum NullReferenceException sau sa se execute cod la aruncarea unui eveniment pe care noi nu ne-am astepta sa se execute.
Ce putem sa facem ca sa rezolvam aceasta problema?
Avem la indemana doua solutii. Prima varianta este sa eliminam virtual si override. O sa fie nevoie sa ne declaram o metode de tip "event-firing" in clasa de baza. Aceasta metoda o sa fie adaugata in clasa de baza si tot ce va face este sa arunce evenimentul nostru. In clasa derivata nu se va folosii direct evenimentul ci se va apela metoda pe care noi am declarato in clasa de baza. Iar aceata la randul ei o sa arunce evenimentul. Mai jos puteti sa gasiti implementarea propusa:
public class Base
{
public event EventHandler EventOne;
public void FireEventOne(object sender, EventArgs args)
{
if (EventOne != null)
{
EventOne(sender, args);
}
}
}
public class Derived
{
public void DoAction()
{
...
FireEventOne(this, args);
}
}

In varianta data mai sus, clasa derivata nu mai poate sa faca override la eveniment, aceasta putand doar sa se inscrie la acest eveniment. Field-ul EventOne nu o sa mai fie duplicat in clasa de baza. Prim aceasta metoda am eliminat orice comportament ciudat care ar fi putut sa apara.
Daca avem nevoie sa facem override, atunci va recomand sa mergeti pe varianta in care in clasa de baza evenimentul sa fie declarat ca si abstract( nu consider aceasta variata ca fiind cea mai sanatoasa).
public class Base
{
public abstract event EventHandler EventOne;
}
Va recomand sa va ganditi de doua ori daca chiar aveti nevoie de un eveniment abstract. S-ar putea ca design-ul pe care l-ati ales sa nu fie cel mai bun.

Comments

  1. Pai cred ca prima intrebare ar fi: de ce ar avea nevoie cineva sa declare un event .. virtual si sa faca override la el?

    La urma urmei, event EventHandler nu e decat o colectie de delegates..

    Eventual daca vrea sa customizeze modul in care sunt stocati acei delegates folosing add/remove accessors sau sa fie thread-safe, da' ..

    ReplyDelete
  2. Si mie mi se pare un pic trasa de par. Iar FireEventOn - numita , de obicei, OnEventOne e ceea ce fac de obicei.

    ReplyDelete
  3. In doua proiecte diferite am vazut problema asta. Partea buna ii ca ReSharper-ul urla destul de tare cand vede probleme de genul acesta.

    ReplyDelete
  4. La http://blogs.msdn.com/b/samng/archive/2007/11/26/virtual-events-in-c.aspx se pare ca explica un nene de la Microsoft mai in detaliu care e problema, si de ce nu o pot fixa cum ar vrea..

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(...

How to audit an Azure Cosmos DB

In this post, we will talk about how we can audit an Azure Cosmos DB database. Before jumping into the problem let us define the business requirement: As an Administrator I want to be able to audit all changes that were done to specific collection inside my Azure Cosmos DB. The requirement is simple, but can be a little tricky to implement fully. First of all when you are using Azure Cosmos DB or any other storage solution there are 99% odds that you’ll have more than one system that writes data to it. This means that you have or not have control on the systems that are doing any create/update/delete operations. Solution 1: Diagnostic Logs Cosmos DB allows us activate diagnostics logs and stream the output a storage account for achieving to other systems like Event Hub or Log Analytics. This would allow us to have information related to who, when, what, response code and how the access operation to our Cosmos DB was done. Beside this there is a field that specifies what was th...

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills)

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills) The idea that moving to the cloud reduces the costs is a common misconception. The cloud infrastructure provides flexibility, scalability, and better CAPEX, but it does not guarantee lower costs without proper optimisation and management of the cloud services and infrastructure. Idle and unused resources, overprovisioning, oversize databases, and unnecessary data transfer can increase running costs. The regional pricing mode, multi-cloud complexity, and cost variety add extra complexity to the cost function. Cloud adoption without a cost governance strategy can result in unexpected expenses. Improper usage, combined with a pay-as-you-go model, can result in a nightmare for business stakeholders who cannot track and manage the monthly costs. Cloud-native services such as AI services, managed databases, and analytics platforms are powerful, provide out-of-the-shelve capabilities, and increase business agility and innovation. H...