Skip to main content

OR logic si AND logic - never say never

Mi-am adus aminte de o experienta nefericita pe care am avuto la începutului anului cu operatorii logici.
Era nevoie să fac debug pe un OR logic intre un ulong si un int.
int sursa1;
ulong sursa2;
Init(sursa1,sursa2);
ulong stare=sursa2 | sursa1;
Din pacate nu puteam sa folosesc enum. Era o aplicație vechie, care a fost portata de cineva in C# si era plina de erori de compilare. Nimeni nu cunoștea exact care sunt stariile in care se poate ajunge variabila stare si ce înseamnă fiecare stare.
Prima problema pe care o aveam era ca linia de cod care facea OR logic, codul nu compila deloc din cauza ca cele doua date( sursa1 si sursa2) erau de tipuri diferite. Eroarea pe care o primeam era "Operator | cannot be applied to operands of type int and ulong.". Era normal sa avem aceasta eroare, deoarece sursa2 era strict pozitiva, in comparație cu sursa1 care era o variabila cu semn(+/-).
Nici o problema am zis:
ulong stare= sursa2 | (ulong) sursa1;
Codul a compilat, aveam un warning legat de modul in care se face casting-ul dar am zis ca e okay si am trecut mai departe. Dupa o zi sau doua am ajuns sa rulez aplicatia si surpriza, valoriile pe care le optineam in urma OR logic erau eronate. Obtineam niste valori care nu aveau nici o legatura cu valoriile pe care le asteptam.
Am stat cîteva ore bune pana să îmi dau seama ce se întîmpla. Problema apărea din modul in care se face CAST. Noi vrem să obținem un ulong din int. Dar conversia care se face nu este directa, de la int la ulong, asa cum poate ne-am astepta. Pășii pe care ii face .NET sunt:
int -> long -> ulong
Prima data int este convertit in long iar apoi in ulong. In momentul in care se face conversia la long valoarea pe care noi am asteptao se pierde in totalitate.
Solutia pe care am gasito, desi pare ciudata este:
ulong rezultat = sursa 2 | (ulong)(long) sursa1;
Ciudat nu? Eu zic ca e destul de ciudat. Cand lucrati cu OR logic sau AND logic, incercati sa evitati sa lucrati cu tipuri diferite de date. Recomandarea mea este sa evitati OR logic. Puteți folosii cu succes, enum-ul in acest caz, unde fiecare stare sa aibe o anumita valorea binara(FLAG).
Exemplu:
    [Flags]
enum FileType
{
None = 0x0,
Exe = 0x1,
Zip = 0x2,
Video = 0x4,
Sound = 0x8,
D3 = 0x10
}




Problema era ca rezultatul care era obtinut in urma acestui OR logic nu era cel asteptat.

Comments

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(...

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see...

Navigating Cloud Strategy after Azure Central US Region Outage

 Looking back, July 19, 2024, was challenging for customers using Microsoft Azure or Windows machines. Two major outages affected customers using CrowdStrike Falcon or Microsoft Azure computation resources in the Central US. These two outages affected many people and put many businesses on pause for a few hours or even days. The overlap of these two issues was a nightmare for travellers. In addition to blue screens in the airport terminals, they could not get additional information from the airport website, airline personnel, or the support line because they were affected by the outage in the Central US region or the CrowdStrike outage.   But what happened in reality? A faulty CrowdStrike update affected Windows computers globally, from airports and healthcare to small businesses, affecting over 8.5m computers. Even if the Falson Sensor software defect was identified and a fix deployed shortly after, the recovery took longer. In parallel with CrowdStrike, Microsoft provi...