Skip to main content

[Code refactoring] Multiple Threads - Locks and Mutex

Each of us know what is lock and what its purpose is. It is used to block a critical section of code – the statements from the lock block will be executed only by one thread at the same time.
public class Foo
{
  FooConnection con;
  
  public void OpenConnection()
  {
    ...
    con.Open();
  }

  public void CloseConnection()
  {
    ...
    con.Close();    
  }

  public void Write(...)
  {
    ...
    con.Write(...);
  }
  
  public object Read()
  {
    ...
    ... con.Read();
    ...
  }
}

...
Foo foo = ...;
foo.OpenConnection();
foo.Read();
foo.Read();
...
foo.Read();
foo.RWRWRWR..();
foo.CloseConnection();
Being in a multi-thread environment problems with multiple access to the same resources appeared, information started to be corrupted and many more. For example, multiple read and write started to execute at the same time and having only one connection (cursor) the information retrieved was corrupted.
Because there was only one instance of Foo, locks were added to Read and Write operations. They could not add locks in the locations where Read and Write methods because there were different flows and combinations.

  public void Write(...)
  {
    lock(padLock)
    {
      ...
      con.Write(...);
    }
  }
  
  public object Read()
  {
    lock(padLock)
    {
      ...
      ... con.Read();
      ...
    }
  }
The application started to work better, but they still observed that from time to time they have the same concurrence problems that cause the application to crash.
Can you spot the problem?
Even if lock block the access to a critical section, this is not the solution for our case. We need to make Read/Write operations atomic and to not allow a Read or Write operation to be executed in the same time.
To resolve this problem we have two simple solutions. The most simple fix, that would work for short time is using a Mutex. It is a synchronization primitive similar with a semaphore that has the size 1.
public class Foo
{
  FooConnection con;
  Mutex mutex = new Mutex();
  
  public void OpenConnection()
  {
    ...
    con.Open();
  }

  public void CloseConnection()
  {
    ...
    con.Close();    
  }

  public void Write(...)
  {
    mutex.WaitOne();
    ...
    con.Write(...);
    mutex.ReleaseMutex();    
  }
  
  public object Read()
  {    
    mutex.WaitOne();
    ...
    ... con.Read();
    ...
    mutex.ReleaseMutex();
  }
}
Using a Mutex, we can ensure that only one thread will execute the code from Read or Write block. We will not have cases when on one thread execute the Read method and the other one executes the Write operation.
Other solutions could be used based on transaction or connection pattern (similar with the one that we use in ORM framework.

Comments

  1. There is only one way that the Mutex would work, and that is making the application run slower. Because Mutex is an interprocess communication synchronization object, being therefore heavier than the use of a simple lock. So this works as long as you want interprocess communication locking.

    The first method should've worked... but it is more likely that the problem is caused by the fact that one of the threads closed the resource too fast or opened the resource too late. First of all, you want to add locking around opening and closing, and second of all, you want to clear that handle when it's closed/not opened.

    ReplyDelete

Post a Comment

Popular posts from this blog

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine:
threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration:

TeamCity.NET 4.51EF 6.0.2VS2013
It seems that there …

How to check in AngularJS if a service was register or not

There are cases when you need to check in a service or a controller was register in AngularJS.
For example a valid use case is when you have the same implementation running on multiple application. In this case, you may want to intercept the HTTP provider and add a custom step there. This step don’t needs to run on all the application, only in the one where the service exist and register.
A solution for this case would be to have a flag in the configuration that specify this. In the core you would have an IF that would check the value of this flag.
Another solution is to check if a specific service was register in AngularJS or not. If the service was register that you would execute your own logic.
To check if a service was register or not in AngularJS container you need to call the ‘has’ method of ‘inhector’. It will return TRUE if the service was register.
if ($injector.has('httpInterceptorService')) { $httpProvider.interceptors.push('httpInterceptorService&#…

Fundamental Books of a Software Engineer (version 2018)

More then six years ago I wrote a blog post about fundamental books that any software engineer (developer) should read. Now it is an excellent time to update this list with new entries.

There are 5 different categories of books, that represent the recommended path. For example, you start with Coding books, after that, you read books about Programming, Design and so on.
There are some books about C++ that I recommend not because you shall know C++, only because the concepts that you can learn from it.

Coding

Writing solid codeCode completeProgramming Pearls, more programming pearls(recommended)[NEW] Introduction to Algorithms

Programming

Refactoring (M. Fowler)Pragmatic ProgrammerClean code[NEW] Software Engineering: A Practitioner's Approach[NEW] The Mythical Man-Month[NEW] The Art of Computer Programming

Design

Applying UML and Patterns (GRASP patterns)C++ coding standards (Sutter, Alexandrescu)The C++ programming language (Stroustrup, Part IV)Object-oriented programming (Peter Coad)P…