Skip to main content

MVC 3 - Handling 404 errors

Intr-un post anterior am promis ca o sa revin cu cativa pasi ce trebuie facuti pentru a putea face handling corect la o aplicatie ASP.NET MVC 3.
Mai jos o sa gasiti cei 3 pasi care trebuie facuti pentru a face handling la erorile de tip 404 cat mai bine, fara sa avem surprize neplacute cand aplicatia este deja in productie. Exista mai multe variante. Varianta aleasa de mine nu necesita existenta sau modificarea unui base controller.
1. Pentru toate erorile care apar in sistem avem nevoie de un loc comun
Toate erorile trebuie sa fie controlate dintr-un loc comun. In cazul in care vrem sa vedem la ce erori se face handling sau care este modalitatea prin care se face handling, ca sa nu cautam prin controale, cel mai usor este sa ne facem un controller care se ocupa doar cu acest lucru. public
class ErrorController
{
    public ActionResult Http404(string url)
    {
        Response.StatusCode = (int)HttpStatusCode.NotFound;
        var model = new ErrorViewModel();
        model.RequestedUrl = Request.Url.OriginalString.Contains(url) & Request.Url.OriginalString != url
                ? Request.Url.OriginalString
                : url;
        model.ReferrerUrl = Request.UrlReferrer != null
                && Request.UrlReferrer.OriginalString != model.RequestedUrl
                ? Request.UrlReferrer.OriginalString
                : null;
        return View("NotFound", model);
    }
}
In interiorul actiunii Http404 se pot scrie informatii in trace cu privire la eroarea aparuta.
2. Handling la erorile de tip 404 din fisierul de configurare
In web.config trebuie sa facem handling la erorile de tip 404 in doua locatii.
<system.webServer>
    <httpErrors errorMode="Custom">
      <remove statusCode="404" subStatusCode="-1" />
      <error statusCode="404" path="/Error/Http404" responseMode="ExecuteURL" />
      <remove statusCode="500" subStatusCode="-1" />
      <error statusCode="500" path="/Error/ServerError" responseMode="ExecuteURL" />
    </httpErrors>   
<system.webServer>
</system.web>
si
<system.web>
    <customErrors mode="On" defaultRedirect="/Error/Http404">
      <error statusCode="404" redirect="/Error/ServerError" />
    </customErrors>
</system.web>
De foarte multe ori se uita de sectiune httpErrors, care poate sa genereze uneori probleme.
3. Global.asax - custom routes
Cand definim "tabela" pentru routes, nu trebuie sa uitam sa mapam erorile de tip 404 si sa le redirectionam spre controlerul de erori.
routes.MapRoute(
        "Error - 404",
        "NotFound",
        new { controller = "Error", action = "Http404" }
        );
    routes.MapRoute(
        "Error - 500",
        "ServerError",
        new { controller = "Error", action = "ServerError"}
        );
Este foarte important ca aceste doua route sa fie primele definite. Dupa aceste route putem sa adaugam cele custom pentru aplicatia noastra.

Exista si alte variante. Aceasta mi s-a parut destul ca nu genereaza modificari de cod si in alte zone, unde poate nu vrem sa facem nici o modificare.

Comments

  1. Interesant - mai greu e de decis ce sa apara in pagina de 404 not found - macar un link care sa duca user-ul inapoi la aplicatie, poate un feature de search cand e posibil: http://www.codinghorror.com/blog/2007/03/creating-user-friendly-404-pages.html

    ReplyDelete
  2. Dar daca toata aplicatia este down se poate crea o bucla din cauza redirectariilor. Trebuie avut grija daca folosim un controller pentru Erori, ca acesta sa fie cat mai simplu si de evitat sa mosteneasca din ceva BaseController a aplicatiei noastre.
    Cea mai sigura varianta pagini HTML simple.

    ReplyDelete
  3. Mie personal mi se pare gresit (dpdv SEO) sa redirectionezi in caz de URL inexistent. In mod normal ar trebui sa raspunzi cu 404 si URL-ul sa nu se schimbe in browser.

    ReplyDelete
    Replies
    1. Exista cazuri cand eroarea 404 iti scapa din cod si aici e ultimul loc unde o poti prinde (sau din cod, dar tot pe baza unei configurati asemanatoare).

      Delete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(...

How to audit an Azure Cosmos DB

In this post, we will talk about how we can audit an Azure Cosmos DB database. Before jumping into the problem let us define the business requirement: As an Administrator I want to be able to audit all changes that were done to specific collection inside my Azure Cosmos DB. The requirement is simple, but can be a little tricky to implement fully. First of all when you are using Azure Cosmos DB or any other storage solution there are 99% odds that you’ll have more than one system that writes data to it. This means that you have or not have control on the systems that are doing any create/update/delete operations. Solution 1: Diagnostic Logs Cosmos DB allows us activate diagnostics logs and stream the output a storage account for achieving to other systems like Event Hub or Log Analytics. This would allow us to have information related to who, when, what, response code and how the access operation to our Cosmos DB was done. Beside this there is a field that specifies what was th...

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see...