Code Review and Under Stress Teams

Nowadays, being agile is a trend. All the projects are agile in their own sense and of course each task needs to be reviewed. Today I would like to write about the review step.
The code review step is the process when a person looks over the code and tries to find mistakes that were missed by the developer that wrote that code. There are different ways how reviews are made. Normally, in big teams the review is made separately, without pair programing or similar things.
Because people don’t make the code review as they should, the value of this process decreases. In the end the management will realize that there is no value in code reviews and they will stop allocating time for this.

Why did they end up with this bad idea?
Because THE developers that are doing the reviews are not doing it right.
For example when the developer doesn’t have time for all tasks and is using the review time to finish other tasks. In this case the review will not be made. In the best case scenario they will only look over the code for 2-3 minutes. We will end up with a task that was not reviewed.
Another case is when the review is made because you have to do it. In this case you can end up with funny situations like a task that doesn’t contains any change sets is moved from review state to ready for tests. Even if theoretically the task contains some code changes (the developer assigned the change set to a wrong task id). For me this is a sign that the review will not be made by the team.
The review time consumes a lot of resources and because the review is not made any more the management team will not see the value of it. They will still have major bugs; the quality of code is not good and so on.
What we could do in this case? How can we improve the process?
As one of my friend would say: KILL the team – they need to suffer! Pair programing is nice, but is not possible in all the situations.
Of course this is not a solution and we need to think at something that could motivate the team. The developers and PM should talk and see why the reviews are not made. There are a lot of reasons but in a team with a lot of good developers, the main reason I expect to be the TIME. Developers should require real time for review and not only virtual time.
Also, reviewing a sprint backlog item can hide mistakes. Reviewing a product backlog item could be more useful. To understand the real problem and the context, there are times when looking only on small task will not help understand the problem. More and more often I encourage this practice, because is more easily to see the real problems of the current solution (see next paragraph).
Educate the team how a review needs to be made. A code review is not only code styling review – filed name, class name, method name and things like that. When making a review we should look over other things like unit tests – Does the current implementation has unit tests? How the current implementation is integrated in the solution? Is the current solution good?
If you end up in this situation, I would not remove the review time. I would try to motivate team and why not change the rules of the game. An interesting solution for this problem would be to change the owner of a task from the person how implemented to the one that makes the review. In this way the person that makes the review will know that after he will mark the task as OK, he will be owner and responsible for the it.

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(

Azure AD and AWS Cognito side-by-side

In the last few weeks, I was involved in multiple opportunities on Microsoft Azure and Amazon, where we had to analyse AWS Cognito, Azure AD and other solutions that are available on the market. I decided to consolidate in one post all features and differences that I identified for both of them that we should need to take into account. Take into account that Azure AD is an identity and access management services well integrated with Microsoft stack. In comparison, AWS Cognito is just a user sign-up, sign-in and access control and nothing more. The focus is not on the main features, is more on small things that can make a difference when you want to decide where we want to store and manage our users. This information might be useful in the future when we need to decide where we want to keep and manage our users. Feature Azure AD (B2C, B2C) AWS Cognito Access token lifetime Default 1h – the value is configurable 1h – cannot be modified

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see

AnonymousJune 10, 2013 at 3:39 PM
I think also the management (team leads, PMs etc..) are responsible in this case: they should understand the role of a code review and (more importantly) understand the value of code refactoring afterwards - more often than not this is why the developers loose interest in code reviews - the managers see no value in this activity and perceive the time spend in code review and refactorings as time that should be "hidden" from the client ("the client should not find out that we are spending time on code reviews") :)

Cloud as a Story - Vunvulea Radu

Search This Blog