Skip to main content

Code Review: Class Comments

Let's talk in this post about code comments, around the following example.
    /// <summary>
    /// ... summary comments ...
    /// Note: If you change environment make sure you clear this file,as it will contain cached configuration
    /// </summary>
    public class ConfigurationPersister
    {        
        public T GetConfiguration<T>() { ... }        
        public void PersistConfiguration<T>(T configuration) { ... }
        internal bool HasConfiguration<T>() { ... }        
        private string CreateConfigFileName(string fileName) { ... }        
        private void CheckConfigDirectory() { ... }        
    }

Tags
First thing that we might notify is the 'NOTE' part. For this kind of scenarios we should use custom tags like '<remarks>'. In this way the other developer that is using the ConfigurationPersister (class), can see more clearly any remarks.
    /// <summary>
    /// ... summary comments ...
    /// <summary>
    /// <remarks>If you change environment make sure you clear this file,as it will contain cached configuration
    /// </remarks>
    public class ConfigurationPersister
    {        
        public T GetConfiguration<T>() { ... }        
        public void PersistConfiguration<T>(T configuration) { ... }
        internal bool HasConfiguration<T>() { ... }        
        private string CreateConfigFileName(string fileName) { ... }        
        private void CheckConfigDirectory() { ... }        
    }

In the summary, you should add only the content that is relevant. We should try to use other types of tags like '<remarks>' or '<see>', based on what kind of content we want to add there.

Location
The second thing that we notify is related what kind of information is specified in '<remarks>' tag. The comment specify that we should clean the content of the file if we change the environment. For the person that will use the application how does this information will be relevant?
Once you compile the code the comments are not relevant anymore for end user. The end user cannot see any kind of code comments.

Taking this into consideration, this comment should be added in a location where the end user can access it. In this case, this comment should be added inside the file where configuration is stored.
If the configuration file is generated dynamically,  we should push the comment from our code to the config. file.
<!--If you change environment make sure you clear this file,as it will contain cached configuration-->
<configuration>
  <ip>158.541.245.124</ip>
  <port>443</port>
</configuration>

Message

The last thing related to the message that is transmitted by the comment. A end user might not understand what does clear file means. It might be deleting the file, remove all content, remove a specific content from file.For end user it might not be clear what does change environment means.
It is recommended to provide clear information and try to define as clear as possible all actions. If you have at application level a glossary that defines clearly what each term or action means, that we are okay.

Conclusion
Before adding a comment try to:

  • See what is the real value of the comment
  • Why you need to add it 
  • Does the person that will read the comment will understand it
  • It is the right location (a message for end-user should never be added as code comment)

Comments

  1. If the configuration file is generated dynamically, we should push the comment from our code to the config. file.https://www.avaza.com

    ReplyDelete

Post a Comment

Popular posts from this blog

Windows Docker Containers can make WIN32 API calls, use COM and ASP.NET WebForms

After the last post , I received two interesting questions related to Docker and Windows. People were interested if we do Win32 API calls from a Docker container and if there is support for COM. WIN32 Support To test calls to WIN32 API, let’s try to populate SYSTEM_INFO class. [StructLayout(LayoutKind.Sequential)] public struct SYSTEM_INFO { public uint dwOemId; public uint dwPageSize; public uint lpMinimumApplicationAddress; public uint lpMaximumApplicationAddress; public uint dwActiveProcessorMask; public uint dwNumberOfProcessors; public uint dwProcessorType; public uint dwAllocationGranularity; public uint dwProcessorLevel; public uint dwProcessorRevision; } ... [DllImport("kernel32")] static extern void GetSystemInfo(ref SYSTEM_INFO pSI); ... SYSTEM_INFO pSI = new SYSTEM_INFO(

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine: threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration: TeamCity .NET 4.51 EF 6.0.2 VS2013 It see

Navigating Cloud Strategy after Azure Central US Region Outage

 Looking back, July 19, 2024, was challenging for customers using Microsoft Azure or Windows machines. Two major outages affected customers using CrowdStrike Falcon or Microsoft Azure computation resources in the Central US. These two outages affected many people and put many businesses on pause for a few hours or even days. The overlap of these two issues was a nightmare for travellers. In addition to blue screens in the airport terminals, they could not get additional information from the airport website, airline personnel, or the support line because they were affected by the outage in the Central US region or the CrowdStrike outage.   But what happened in reality? A faulty CrowdStrike update affected Windows computers globally, from airports and healthcare to small businesses, affecting over 8.5m computers. Even if the Falson Sensor software defect was identified and a fix deployed shortly after, the recovery took longer. In parallel with CrowdStrike, Microsoft provided a too