Skip to main content

[Code refactoring] Multiple Threads - Locks and Mutex

Each of us know what is lock and what its purpose is. It is used to block a critical section of code – the statements from the lock block will be executed only by one thread at the same time.
public class Foo
{
  FooConnection con;
  
  public void OpenConnection()
  {
    ...
    con.Open();
  }

  public void CloseConnection()
  {
    ...
    con.Close();    
  }

  public void Write(...)
  {
    ...
    con.Write(...);
  }
  
  public object Read()
  {
    ...
    ... con.Read();
    ...
  }
}

...
Foo foo = ...;
foo.OpenConnection();
foo.Read();
foo.Read();
...
foo.Read();
foo.RWRWRWR..();
foo.CloseConnection();
Being in a multi-thread environment problems with multiple access to the same resources appeared, information started to be corrupted and many more. For example, multiple read and write started to execute at the same time and having only one connection (cursor) the information retrieved was corrupted.
Because there was only one instance of Foo, locks were added to Read and Write operations. They could not add locks in the locations where Read and Write methods because there were different flows and combinations.

  public void Write(...)
  {
    lock(padLock)
    {
      ...
      con.Write(...);
    }
  }
  
  public object Read()
  {
    lock(padLock)
    {
      ...
      ... con.Read();
      ...
    }
  }
The application started to work better, but they still observed that from time to time they have the same concurrence problems that cause the application to crash.
Can you spot the problem?
Even if lock block the access to a critical section, this is not the solution for our case. We need to make Read/Write operations atomic and to not allow a Read or Write operation to be executed in the same time.
To resolve this problem we have two simple solutions. The most simple fix, that would work for short time is using a Mutex. It is a synchronization primitive similar with a semaphore that has the size 1.
public class Foo
{
  FooConnection con;
  Mutex mutex = new Mutex();
  
  public void OpenConnection()
  {
    ...
    con.Open();
  }

  public void CloseConnection()
  {
    ...
    con.Close();    
  }

  public void Write(...)
  {
    mutex.WaitOne();
    ...
    con.Write(...);
    mutex.ReleaseMutex();    
  }
  
  public object Read()
  {    
    mutex.WaitOne();
    ...
    ... con.Read();
    ...
    mutex.ReleaseMutex();
  }
}
Using a Mutex, we can ensure that only one thread will execute the code from Read or Write block. We will not have cases when on one thread execute the Read method and the other one executes the Write operation.
Other solutions could be used based on transaction or connection pattern (similar with the one that we use in ORM framework.

Comments

  1. There is only one way that the Mutex would work, and that is making the application run slower. Because Mutex is an interprocess communication synchronization object, being therefore heavier than the use of a simple lock. So this works as long as you want interprocess communication locking.

    The first method should've worked... but it is more likely that the problem is caused by the fact that one of the threads closed the resource too fast or opened the resource too late. First of all, you want to add locking around opening and closing, and second of all, you want to clear that handle when it's closed/not opened.

    ReplyDelete

Post a Comment

Popular posts from this blog

ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded

Today blog post will be started with the following error when running DB tests on the CI machine:
threw exception: System.InvalidOperationException: The Entity Framework provider type 'System.Data.Entity.SqlServer.SqlProviderServices, EntityFramework.SqlServer' registered in the application config file for the ADO.NET provider with invariant name 'System.Data.SqlClient' could not be loaded. Make sure that the assembly-qualified name is used and that the assembly is available to the running application. See http://go.microsoft.com/fwlink/?LinkId=260882 for more information. at System.Data.Entity.Infrastructure.DependencyResolution.ProviderServicesFactory.GetInstance(String providerTypeName, String providerInvariantName) This error happened only on the Continuous Integration machine. On the devs machines, everything has fine. The classic problem – on my machine it’s working. The CI has the following configuration:

TeamCity.NET 4.51EF 6.0.2VS2013
It seems that there …

Entity Framework (EF) TransactionScope vs Database.BeginTransaction

In today blog post we will talk a little about a new feature that is available on EF6+ related to Transactions.
Until now, when we had to use transaction we used ‘TransactionScope’. It works great and I would say that is something that is now in our blood.
using (var scope = new TransactionScope(TransactionScopeOption.Required)) { using (SqlConnection conn = new SqlConnection("...")) { conn.Open(); SqlCommand sqlCommand = new SqlCommand(); sqlCommand.Connection = conn; sqlCommand.CommandText = ... sqlCommand.ExecuteNonQuery(); ... } scope.Complete(); } Starting with EF6.0 we have a new way to work with transactions. The new approach is based on Database.BeginTransaction(), Database.Rollback(), Database.Commit(). Yes, no more TransactionScope.
In the followi…

GET call of REST API that contains '/'-slash character in the value of a parameter

Let’s assume that we have the following scenario: I have a public HTTP endpoint and I need to post some content using GET command. One of the parameters contains special characters like “\” and “/”. If the endpoint is an ApiController than you may have problems if you encode the parameter using the http encoder.
using (var httpClient = new HttpClient()) { httpClient.BaseAddress = baseUrl; Task<HttpResponseMessage> response = httpClient.GetAsync(string.Format("api/foo/{0}", "qwert/qwerqwer"))); response.Wait(); response.Result.EnsureSuccessStatusCode(); } One possible solution would be to encode the query parameter using UrlTokenEncode method of HttpServerUtility class and GetBytes method ofUTF8. In this way you would get the array of bytes of the parameter and encode them as a url token.
The following code show to you how you could write the encode and decode methods.
publ…