Skip to main content

Code refactoring - NULL check

Part 1
Part 2
Part 3

Let’s look over the following code:
public class Foo
{
  SomeFoo _some;
  
  ...

  public int GetA()
  {
    if(_some == null)
    {
      return 0;
    }

    return _some.A;
  }

  public string GetB()
  {
    if(_some == null)
    {
      return null;
    }

    return _some.B;
  }

  public int GetTotalX()
  {
    if(_some == null)
    {
      return -1;
    }

    return _some.A + _some.C;
  }

}
We can see that the IF checks appears in more than one place. Even if is only a simple check, there can be a lot of places where it appears.
If we manage to extract this check in a generic method, than the code would be more legible. Because we don’t return each time the default value of an object we need to be able to return custom “default” value for the case when or object is null.
We can image a method that accept as parameter the object that we check if is null or not and another two parameters that represent the default value that need to be return and a generic function that return the expected value.
private TReturn ExecuteFuncOverObj<TReturn>(object obj, TReturn defaultValue, Func<TReturn> func)
{
  if( obj == null)
  {
    return defaultValue;
  }

  return func.Invoke();
}
In this way our code would look like this:

public class Foo
{
  SomeFoo _some;
  
  ...

  public int GetA()
  {
    return ExecuteFuncOverObj(_some, () => _some.A, 0);
  }

  public string GetB()
  {
    return ExecuteFuncOverObj(_some, () => _some.B, null);
  }

  public int GetTotalX()
  {

    return ExecuteFuncOverObj(_some, () => _some.A + _some.C, -1);
  }

}
If we need this behavior in other methods we could define a helper function or an extension method of Object.
Enjoy!
Part 1
Part 2
Part 3

Comments

  1. In Java it is recommended (and I would imagine C# is quite similar) that you don't use null, rather a "neutral" object. For example empty maps / lists / sets, 0, empty string etc. (depending on the context in which the object will be used).

    ReplyDelete
    Replies
    1. Indeed, another name for this would be the "null object pattern" or "special case pattern" (http://martinfowler.com/eaaCatalog/specialCase.html).
      Anyway, this would require to wrap all external classes if they are subject to null checks.

      Delete
  2. So you suggest that in order to avoid having an if, we create a new function call and we pass it a lambda function? I fail to see the benefit here. It's 1) counterintuitive 2) requires that a new developer using that code understand a new layer of indirection and 3) it's wasted resources. Of course, the approach can be optimized by the compiler, but the strategy explains why typical and advanced high-level languages users produce bloated solutions.

    ReplyDelete

Post a Comment

Popular posts from this blog

Why Database Modernization Matters for AI

  When companies transition to the cloud, they typically begin with applications and virtual machines, which is often the easier part of the process. The actual complexity arises later when databases are moved. To save time and effort, cloud adoption is more of a cloud migration in an IaaS manner, fulfilling current, but not future needs. Even organisations that are already in the cloud find that their databases, although “migrated,” are not genuinely modernised. This disparity becomes particularly evident when they begin to explore AI technologies. Understanding Modernisation Beyond Migration Database modernisation is distinct from merely relocating an outdated database to Azure. It's about making your data layer ready for future needs, like automation, real-time analytics, and AI capabilities. AI needs high throughput, which can be achieved using native DB cloud capabilities. When your database runs in a traditional setup (even hosted in the cloud), in that case, you will enc...

Cloud Myths: Migrating to the cloud is quick and easy (Pill 2 of 5 / Cloud Pills)

The idea that migration to the cloud is simple, straightforward and rapid is a wrong assumption. It’s a common misconception of business stakeholders that generates delays, budget overruns and technical dept. A migration requires laborious planning, technical expertise and a rigorous process.  Migrations, especially cloud migrations, are not one-size-fits-all journeys. One of the most critical steps is under evaluation, under budget and under consideration. The evaluation phase, where existing infrastructure, applications, database, network and the end-to-end estate are evaluated and mapped to a cloud strategy, is crucial to ensure the success of cloud migration. Additional factors such as security, compliance, and system dependencies increase the complexity of cloud migration.  A misconception regarding lift-and-shits is that they are fast and cheap. Moving applications to the cloud without changes does not provide the capability to optimise costs and performance, leading to ...

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills)

Cloud Myths: Cloud is Cheaper (Pill 1 of 5 / Cloud Pills) The idea that moving to the cloud reduces the costs is a common misconception. The cloud infrastructure provides flexibility, scalability, and better CAPEX, but it does not guarantee lower costs without proper optimisation and management of the cloud services and infrastructure. Idle and unused resources, overprovisioning, oversize databases, and unnecessary data transfer can increase running costs. The regional pricing mode, multi-cloud complexity, and cost variety add extra complexity to the cost function. Cloud adoption without a cost governance strategy can result in unexpected expenses. Improper usage, combined with a pay-as-you-go model, can result in a nightmare for business stakeholders who cannot track and manage the monthly costs. Cloud-native services such as AI services, managed databases, and analytics platforms are powerful, provide out-of-the-shelve capabilities, and increase business agility and innovation. H...